jnh5y commented on code in PR #25777:
URL: https://github.com/apache/flink/pull/25777#discussion_r1882298429
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData>
createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if
(config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
Review Comment:
The annotations here:
https://github.com/apache/flink/pull/25777/files#diff-76717e3a4ed9896387a0961a4ff297ccd8a7dd4ef19b49605cf0755fb1d0d1dbR73-R78
show provide information about how to serialize this node to JSON.
Checkout other examples and you'll see a field named `consumedOptions` which
tells which options are used the node.
If I understand, you are adding a new option which is used by this class.
As such, you need to advertise it in the annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
