Au-Miner commented on code in PR #25777:
URL: https://github.com/apache/flink/pull/25777#discussion_r1879803790
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData>
createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if
(config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
+ return new AsyncStateTemporalProcessTimeJoinOperator(
Review Comment:
Thanks for review. This PR is for completing a part of Flip-473. His
intention is similar to https://github.com/apache/flink/pull/25320 .
The original API has not been changed, it will only switch the
TemporalProcessTimeJoinOperator under the FLINK-TABLE module to be executed by
Asynchronous StateTemporalProcessTimeJoinOperator when
table.exe.async-state.enable is set to true.
Is there anything else that needs to be modified? If so, please let me know.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
