jnh5y commented on code in PR #25777:
URL: https://github.com/apache/flink/pull/25777#discussion_r1880400454
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData>
createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if
(config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
Review Comment:
From the other PR, As a heads up, changes like this should update
consumedOptions for the JSON serialization.
(Sorry for splitting the conversation across PRs.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
