davidradl commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1939195889
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -1299,6 +1380,39 @@ private static long ceil(long a, long b) {
}
}
+ private static long ceil(long a, int b) {
+ float q = (float) b / NANOS_PER_MILLISECOND;
+ if (q > 0) {
+ return a + 1L;
+ } else {
+ return a;
+ }
+ }
+
+ private static int ceilForHighPrecision(int b) {
+ long q = b / NANOS_PER_MICROSECOND;
Review Comment:
nit: could we name the variables so they are meaningful please ie. not
single letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
