davidradl commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1949361229
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -1290,6 +1353,24 @@ private static long floor(long a, long b) {
}
}
+ private static long floor(long a, int b) {
Review Comment:
I can see that a and b are used elsewhere. I suggest that it could be
clearer to use timepoint and timeintervalunit as the variable names to match
the documentation. I would also have the full words for q and r. In my view it
would be so much more self describing. Though from googling, I see there is a
school of thought for maths intensive processing single letters are used - I
assume so it looks more like algebra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
