gguptp commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2596332793
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java:
##########
@@ -176,7 +176,7 @@ private <AttributeT> TableSchema<AttributeT>
createTableSchemaFromPojo(
tableSchemaBuilder,
propertyDescriptor.getName(),
BeanAttributeGetter.create(
- typeInfo.getTypeClass(),
propertyDescriptor.getReadMethod()),
+ typeInfo.getTypeClass(),
propertyDescriptor.getReadMethod(), null),
Review Comment:
i wasnt aware there is such thing, will change this
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java:
##########
@@ -138,7 +139,20 @@ public void handleSourceEvent(int subtaskId, SourceEvent
sourceEvent) {
/** When we mark a split as finished, we will only assign its child splits
to the subtasks. */
private void handleFinishedSplits(int subtaskId, SplitsFinishedEvent
splitsFinishedEvent) {
- splitTracker.markAsFinished(splitsFinishedEvent.getFinishedSplitIds());
+ Set<String> finishedSplitIds =
+ splitsFinishedEvent.getFinishedSplits().stream()
+ .map(SplitsFinishedEventContext::getSplitId)
+ .collect(Collectors.toSet());
+ splitTracker.markAsFinished(finishedSplitIds);
+ List<Shard> childrenOfFinishedSplits = new ArrayList<>();
+ splitsFinishedEvent
+ .getFinishedSplits()
+ .forEach(
+ finishedSplitEvent ->
+ childrenOfFinishedSplits.addAll(
+ finishedSplitEvent.getChildSplits()));
+ LOG.info("Adding Children of finishedSplits to splitTracker: {}",
childrenOfFinishedSplits);
Review Comment:
makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
