gguptp commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2596333912
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/reader/DynamoDbStreamsSourceReader.java:
##########
@@ -83,19 +89,40 @@ protected void onSplitFinished(Map<String,
DynamoDbStreamsShardSplitState> finis
splitFinishedEvents.computeIfAbsent(currentCheckpointId, k -> new
HashSet<>());
finishedSplitIds.values().stream()
.map(
- finishedSplit ->
- new DynamoDbStreamsShardSplit(
- finishedSplit.getStreamArn(),
- finishedSplit.getShardId(),
-
finishedSplit.getNextStartingPosition(),
- finishedSplit
- .getDynamoDbStreamsShardSplit()
- .getParentShardId(),
- true))
+ finishedSplit -> {
+ List<Shard> childSplits = new ArrayList<>();
+ String finishedSplitId =
finishedSplit.getSplitId();
+ if (childShardIdMap.containsKey(finishedSplitId)) {
+ List<Shard> childSplitIdsOfFinishedSplit =
+ childShardIdMap.get(finishedSplitId);
+
childSplits.addAll(childSplitIdsOfFinishedSplit);
+ }
+ return new DynamoDbStreamsShardSplit(
+ finishedSplit.getStreamArn(),
+ finishedSplit.getShardId(),
+ finishedSplit.getNextStartingPosition(),
+
finishedSplit.getDynamoDbStreamsShardSplit().getParentShardId(),
+ true,
+ childSplits);
+ })
.forEach(split ->
splitFinishedEvents.get(currentCheckpointId).add(split));
+ Set<SplitsFinishedEventContext> splitsFinishedEventContextMap =
+ finishedSplitIds.values().stream()
+ .map(
+ finishedSplit -> {
+ List<Shard> childSplits = new
ArrayList<>();
+ String finishedSplitId =
finishedSplit.getSplitId();
+ if
(childShardIdMap.containsKey(finishedSplitId)) {
+
childSplits.addAll(childShardIdMap.remove(finishedSplitId));
+ }
+ return new SplitsFinishedEventContext(
+ finishedSplitId, childSplits);
+ })
+ .collect(Collectors.toSet());
Review Comment:
makes sense, i will simplify this
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/util/DynamoDbStreamsProxyProvider.java:
##########
@@ -84,6 +86,25 @@ public ListShardsResult listShards(String streamArn,
@Nullable String lastSeenSh
return listShardsResult;
}
+ @Override
+ public ListShardsResult listShardsWithFilter(String streamArn,
ShardFilter shardFilter) {
+ if (ShardFilterType.CHILD_SHARDS.equals(shardFilter.type())) {
Review Comment:
sure, will change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
