gguptp commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-aws/pull/219#discussion_r2596332955
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java:
##########
@@ -88,6 +89,24 @@ public ListShardsResult listShards(String streamArn,
@Nullable String lastSeenSh
return listShardsResult;
}
+ @Override
+ public ListShardsResult listShardsWithFilter(String streamArn, ShardFilter
shardFilter) {
+ LOG.info("Child shards with filter called, for shardId: {}",
shardFilter.shardId());
+ ListShardsResult listShardsResult = new ListShardsResult();
+
+ try {
+ DescribeStreamResponse describeStreamResponse =
+ this.describeStream(streamArn, shardFilter);
+
listShardsResult.addShards(describeStreamResponse.streamDescription().shards());
+ listShardsResult.setStreamStatus(
+ describeStreamResponse.streamDescription().streamStatus());
+ } catch (Exception e) {
+ LOG.error("DescribeStream with Filter API threw an exception", e);
Review Comment:
yep, this can be a warn rather
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/StreamProxy.java:
##########
@@ -41,6 +42,8 @@ public interface StreamProxy extends Closeable {
*/
ListShardsResult listShards(String streamArn, @Nullable String
lastSeenShardId);
+ ListShardsResult listShardsWithFilter(String streamArn, ShardFilter
shardFilter);
Review Comment:
sure, will add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
