RocMarshal commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2602745578
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java:
##########
@@ -34,6 +34,7 @@ public class JdbcConnectionOptions implements Serializable {
public static final String USER_KEY = "user";
public static final String PASSWORD_KEY = "password";
+ public static final String DATABASE_OPTIONS = "database-options";
Review Comment:
Option 1 sounds better to me .
If it could reference the [1] content during the implementation, that would
be even better.
Alternatively, other elegant implementation approaches are also welcome.
[1] https://github.com/apache/flink-connector-jdbc/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
