och5351 commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2616055170
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/JdbcFactory.java:
##########
@@ -64,6 +64,13 @@ default JdbcDialect createDialect(String compatibleMode) {
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
+ JdbcCatalog createCatalog(
Review Comment:
Hi @RocMarshal,
I think it is necessary due to the change in the optional option
default-database.
For example, if you create a catalog like this:
CREATE CATALOG my_mariadb_catalog WITH (
'type' = 'jdbc',
'base-url' = 'jdbc:mysql://localhost:3306/mydb',
'username' = 'user',
'password' = 'pass'
-- 'default-database' = 'my_db',
);
I think this constructor is necessary, and it was created to handle cases
where the default-database option is not provided in factories like MySQL,
Postgres, etc.
May I ask why you think this part might not be necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
