RocMarshal commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2617193743
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/JdbcFactory.java:
##########
@@ -64,6 +64,13 @@ default JdbcDialect createDialect(String compatibleMode) {
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
+ JdbcCatalog createCatalog(
Review Comment:
IIUC, The callings for
```
JdbcCatalog createCatalog(
ClassLoader classLoader,
String catalogName,
String username,
String pwd,
String baseUrl);
```
are located the `setup` of test classes only.
Methods about #createCatalog the main callings in SPI are shown as
following: instead of the new introduced:
```
JdbcCatalog createCatalog(
ClassLoader classLoader,
String catalogName,
String defaultDatabase,
String username,
String pwd,
String baseUrl);
default JdbcCatalog createCatalog(
ClassLoader classLoader,
String catalogName,
String defaultDatabase,
String username,
String pwd,
String baseUrl,
String compatibleMode) {
if (StringUtils.isNullOrWhitespaceOnly(compatibleMode)) {
return createCatalog(classLoader, catalogName, defaultDatabase,
username, pwd, baseUrl);
}
throw new UnsupportedOperationException(
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
```
Hope this expressed~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
