RocMarshal commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2614644554
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/JdbcFactory.java:
##########
@@ -64,6 +64,13 @@ default JdbcDialect createDialect(String compatibleMode) {
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
+ JdbcCatalog createCatalog(
Review Comment:
Thank @och5351 for the hard work.
May I know why we need introduce the method due to items form my side:
- A: If this method is not introduced, it seems that the target
functionality could still be achieved.
- Taking a step(A)back, even if this method must be introduced to achieve
the intended objective, I have not found any line of code that explicitly calls
this method.
Pls correct me if I'm wrong. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
