RocMarshal commented on code in PR #27580:
URL: https://github.com/apache/flink/pull/27580#discussion_r2800241598
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java:
##########
@@ -312,6 +313,12 @@ public class DefaultExecutionGraph implements
ExecutionGraph, InternalExecutionG
private final ExecutionPlanSchedulingContext
executionPlanSchedulingContext;
+ /**
+ * When the scheduler of the job is not {@link
+ * org.apache.flink.runtime.scheduler.adaptive.AdaptiveScheduler}, the
value will be null.
+ */
+ @Nullable private final JobRescaleConfigInfo jobRescaleConfigInfo;
Review Comment:
Hi, @davidradl
@featzhang proposed a suggestion regarding where the newly added information
should be stored:
https://github.com/apache/flink/pull/27544#pullrequestreview-3788685676
It might be better to discuss it together there.
I’ve briefly looked into it. If we can reach a consensus on that suggestion,
moving the newly added information into the `ExecutionGraphInfo` class so as to
decouple `JobRescaleConfigInfo` from `ExecutionGraph` would also be a good
option.
WDYTA ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
