RocMarshal commented on code in PR #27580:
URL: https://github.com/apache/flink/pull/27580#discussion_r2835665413
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java:
##########
@@ -312,6 +313,12 @@ public class DefaultExecutionGraph implements
ExecutionGraph, InternalExecutionG
private final ExecutionPlanSchedulingContext
executionPlanSchedulingContext;
+ /**
+ * When the scheduler of the job is not {@link
+ * org.apache.flink.runtime.scheduler.adaptive.AdaptiveScheduler}, the
value will be null.
+ */
+ @Nullable private final JobRescaleConfigInfo jobRescaleConfigInfo;
Review Comment:
Thanks for the comments.
From the perspective of a job, whether it supports Rescale depends on
whether it is a streaming job and has AdaptiveScheduler enabled. Whether it
inherently supports Rescale is determined by the enabled scheduler. Therefore,
support for Rescale is not an attribute of the job itself. I still recommend
retaining the original design in FLIP.
And I'd like to hear more suggestions about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
