davidradl commented on code in PR #27580:
URL: https://github.com/apache/flink/pull/27580#discussion_r2834255866
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java:
##########
@@ -312,6 +313,12 @@ public class DefaultExecutionGraph implements
ExecutionGraph, InternalExecutionG
private final ExecutionPlanSchedulingContext
executionPlanSchedulingContext;
+ /**
+ * When the scheduler of the job is not {@link
+ * org.apache.flink.runtime.scheduler.adaptive.AdaptiveScheduler}, the
value will be null.
+ */
+ @Nullable private final JobRescaleConfigInfo jobRescaleConfigInfo;
Review Comment:
yes that seems like a nicer design. I wonder if we can go further; do we
need to expose the scheduler type, why not expose supportsRescale, as a boolean
or have it as an interface on the scheduler. Then in the future more scheduler
types could support rescale. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
