twalthr commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3316718915
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/rules/ResolveCallByArgumentsRule.java:
##########
@@ -781,6 +781,11 @@ public Optional<ChangelogMode> changelogMode() {
return Optional.empty();
}
+ @Override
+ public List<int[]> upsertKeyColumns() {
Review Comment:
Usually we use array of array for index paths. All connector interfaces do
it this way.
```suggestion
public int[][] upsertKeyColumns() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
