raminqaf commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3317902412
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToChangelogTypeStrategy.java:
##########
@@ -46,39 +42,30 @@
@Internal
public final class ToChangelogTypeStrategy {
- private static final String DEFAULT_OP_COLUMN_NAME = "op";
+ // Positional argument indexes for TO_CHANGELOG. Must match the order of
StaticArguments
+ // registered in BuiltInFunctionDefinitions#TO_CHANGELOG; changing one
without the other
+ // silently breaks argument resolution.
+ public static final int ARG_TABLE = 0;
Review Comment:
I would rather keep the name as-is. All the argument are by convention like
`ARG_<argName>` (`op -> ARG_OP`, `op_mapping -> ARG_OP_MAPPING`, `table ->
ARG_TABLE`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
