xintongsong commented on code in PR #698:
URL: https://github.com/apache/flink-agents/pull/698#discussion_r3322909690
##########
api/src/main/java/org/apache/flink/agents/api/event/ChatRequestEvent.java:
##########
@@ -39,17 +40,26 @@ public class ChatRequestEvent extends Event {
private static final ObjectMapper MAPPER = new ObjectMapper();
public ChatRequestEvent(
- String model, List<ChatMessage> messages, @Nullable Object
outputSchema) {
+ String model,
+ List<ChatMessage> messages,
+ @Nullable Map<String, Object> arguments,
Review Comment:
Same here (and other occurrences). It's a bit hard to connect this
`arguments` with the prompt of model setup.
##########
api/src/main/java/org/apache/flink/agents/api/chat/model/BaseChatModelSetup.java:
##########
@@ -108,10 +108,13 @@ public void open() throws Exception {
public abstract Map<String, Object> getParameters();
public ChatMessage chat(List<ChatMessage> messages) {
- return this.chat(messages, Collections.emptyMap());
+ return this.chat(messages, Collections.emptyMap(),
Collections.emptyMap());
}
- public ChatMessage chat(List<ChatMessage> messages, Map<String, Object>
parameters) {
+ public ChatMessage chat(
+ List<ChatMessage> messages,
+ Map<String, Object> arguments,
+ Map<String, Object> parameters) {
Review Comment:
It could be confusing what are the differences between arguments and
parameters. I'd suggest to user more explicit names, e.g., `modelParams`,
`promptArgs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
