weiqingy commented on code in PR #698:
URL: https://github.com/apache/flink-agents/pull/698#discussion_r3328353505
##########
api/src/main/java/org/apache/flink/agents/api/chat/model/BaseChatModelSetup.java:
##########
@@ -108,10 +108,13 @@ public void open() throws Exception {
public abstract Map<String, Object> getParameters();
public ChatMessage chat(List<ChatMessage> messages) {
- return this.chat(messages, Collections.emptyMap());
+ return this.chat(messages, Collections.emptyMap(),
Collections.emptyMap());
}
- public ChatMessage chat(List<ChatMessage> messages, Map<String, Object>
parameters) {
+ public ChatMessage chat(
+ List<ChatMessage> messages,
+ Map<String, Object> arguments,
+ Map<String, Object> parameters) {
Review Comment:
Good call — renamed for clarity in `1aba525`. The two maps are now
`promptArgs` (the prompt-template variables) and `modelParams` (the values
merged into the model request), which also lines up with the model-params
meaning already carried one layer down in `BaseChatModelConnection.chat(...)`.
The same split is threaded through `ChatRequestEvent`, `ChatModelAction`, and
the Pemja bridge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
