weiqingy commented on code in PR #698:
URL: https://github.com/apache/flink-agents/pull/698#discussion_r3328353810
##########
api/src/main/java/org/apache/flink/agents/api/event/ChatRequestEvent.java:
##########
@@ -39,17 +40,26 @@ public class ChatRequestEvent extends Event {
private static final ObjectMapper MAPPER = new ObjectMapper();
public ChatRequestEvent(
- String model, List<ChatMessage> messages, @Nullable Object
outputSchema) {
+ String model,
+ List<ChatMessage> messages,
+ @Nullable Map<String, Object> arguments,
Review Comment:
Renamed here and at the other occurrences in `1aba525`: the constructor
parameter and getter are now `promptArgs` / `getPromptArgs()` (Python
`prompt_args`), and the event attribute, Pemja kwargs key, and persisted
tool-request context key are all `prompt_args`. I left the connection-layer
`arguments` (which means model params) and the LLM tool-call function
`arguments` untouched, since those are separate concepts and out of this
change's scope. I filed #715 to rename the connection-layer `arguments` →
`modelParams` as a follow-up, so the naming is consistent end-to-end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
