weiqingy commented on PR #698: URL: https://github.com/apache/flink-agents/pull/698#issuecomment-4582038803
@xintongsong Thanks for the review! Pushed the changes: - **Naming** (`1aba525`): `arguments` → `promptArgs`/`prompt_args` and the setup-level `parameters` → `modelParams`, across the Java and Python `chat()` surface, `ChatRequestEvent`, `ChatModelAction`, and the Pemja bridge. - **Docs** (`f698fb4`): `prompts.md` and the workflow-agent docs now pass prompt-template variables via `ChatRequestEvent(prompt_args=...)` / the `promptArgs` constructor argument, and I fixed the prose that still referenced `ChatMessage.extra_args`. Updated the documentation checkbox to `doc-included`. I also merged the latest `main` and regenerated the cross-language `ChatRequestEvent` snapshot for the new `prompt_args` attribute (`9411c49`), so CI is green again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
