raminqaf commented on code in PR #29050:
URL: https://github.com/apache/flink/pull/29050#discussion_r3902970194
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantTest.java:
##########
@@ -205,6 +263,9 @@ void testToJsonScalar() {
Instant instant = Instant.EPOCH;
LocalDateTime localDateTime = LocalDateTime.of(2000, 1, 1, 0, 0);
LocalDate localDate = LocalDate.of(2000, 1, 1);
+ LocalTime localTime = LocalTime.of(13, 45, 30, 123456000);
Review Comment:
Let's keep the nano precision with non-zero values for the time here to be
sure that the truncation works as expected
```suggestion
LocalTime localTime = LocalTime.of(13, 45, 30, 123456789);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
