snuyanzin commented on code in PR #29050:
URL: https://github.com/apache/flink/pull/29050#discussion_r3901787399
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -415,8 +445,11 @@ public static long getLong(byte[] value, int pos) {
case DATE:
return readLong(value, pos + 1, 4);
case INT8:
+ case TIME:
case TIMESTAMP_LTZ:
case TIMESTAMP:
+ case TIMESTAMP_LTZ_NS:
+ case TIMESTAMP_NS:
Review Comment:
and by the what will happen with timestamp_NS -300 years?
will it fail or produce some wrong result?
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -415,8 +445,11 @@ public static long getLong(byte[] value, int pos) {
case DATE:
return readLong(value, pos + 1, 4);
case INT8:
+ case TIME:
case TIMESTAMP_LTZ:
case TIMESTAMP:
+ case TIMESTAMP_LTZ_NS:
+ case TIMESTAMP_NS:
Review Comment:
and by the way what will happen with timestamp_NS -300 years?
will it fail or produce some wrong result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
