manner commented on code in PR #29050:
URL: https://github.com/apache/flink/pull/29050#discussion_r3901680728
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -415,8 +445,11 @@ public static long getLong(byte[] value, int pos) {
case DATE:
return readLong(value, pos + 1, 4);
case INT8:
+ case TIME:
case TIMESTAMP_LTZ:
case TIMESTAMP:
+ case TIMESTAMP_LTZ_NS:
+ case TIMESTAMP_NS:
Review Comment:
The Variant specification states 8 bytes for nanosecond timestamps as well.
The downside for using the same 8 bytes for the higher precision values is the
smaller range of timestamps that can be used (+/- 292 years around unix epoch)
<img width="899" height="227" alt="Image"
src="https://github.com/user-attachments/assets/8c6c6a97-381b-454d-8ed2-f8dfcb991764";
/>
https://parquet.apache.org/docs/file-format/types/variantencoding/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
