raminqaf commented on code in PR #29050:
URL: https://github.com/apache/flink/pull/29050#discussion_r3902940969
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -393,16 +417,22 @@ public static boolean getBoolean(byte[] value, int pos) {
}
// Get a long value from variant value `value[pos...]`.
- // It is only legal to call it if `getType` returns one of
`Type.LONG/DATE/TIMESTAMP/
- // TIMESTAMP_LTZ`. If the type is `DATE`, the return value is guaranteed
to fit into an int and
- // represents the number of days from the Unix epoch.
+ // It is only legal to call it if `getType` returns one of
`Type.LONG/DATE/TIME/TIMESTAMP/
+ // TIMESTAMP_LTZ/TIMESTAMP_NS/TIMESTAMP_LTZ_NS`.
+ // If the type is `DATE`, the return value is
+ // guaranteed to fit into an int and represents the number of days from
the Unix epoch.
+ // If the type is `TIME`, the return value represents the number of
microseconds since
+ // midnight.
// If the type is `TIMESTAMP/TIMESTAMP_LTZ`, the return value represents
the number of
// microseconds from the Unix epoch.
+ // If the type is `TIMESTAMP_NS/TIMESTAMP_LTZ_NS`, the return value
represents the number of
+ // nanoseconds from the Unix epoch.
Review Comment:
nit: Should we change this into proper JavaDocs instead of line comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
