davidradl commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3989224313
##########
docs/content.zh/docs/connectors/datastream/http.md:
##########
@@ -61,22 +61,31 @@ These options are specified on the builder using the
setProperty method.
| sink.requests.max-buffered | optional | Maximum
number of buffered records before applying backpressure.
|
| sink.flush-buffer.size | optional | The
maximum size of a batch of entries that may be sent to the HTTP endpoint
measured in bytes.
|
| sink.flush-buffer.timeout | optional |
Threshold time in milliseconds for an element to be in a buffer before being
flushed.
|
-| flink.connector.http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
-| flink.connector.http.sink.error.code | optional | List
of HTTP status codes that should be treated as errors by HTTP Sink, separated
with comma.
|
-| flink.connector.http.sink.error.code.exclude | optional | List
of HTTP status codes that should be excluded from the
`flink.connector.http.sink.error.code` list, separated with comma.
|
-| flink.connector.http.security.cert.server | optional | Path
to trusted HTTP server certificate that should be added to connectors key
store. More than one path can be specified using `,` as path delimiter.
|
-| flink.connector.http.security.cert.client | optional | Path
to trusted certificate that should be used by connector's HTTP client for mTLS
communication.
|
-| flink.connector.http.security.key.client | optional | Path
to trusted private key that should be used by connector's HTTP client for mTLS
communication.
|
-| flink.connector.http.security.cert.server.allowSelfSigned | optional |
Accept untrusted certificates for TLS communication.
|
-| flink.connector.http.sink.request.timeout | optional | Sets
HTTP request timeout for the HTTP sink as a Duration (e.g. `30s`, `1min`). If
not specified, the default value of `30s` will be used.
|
-| flink.connector.http.sink.writer.thread-pool.size | optional | Sets
the size of pool thread for HTTP Sink request processing. Increasing this value
would mean that more concurrent requests can be processed in the same time. If
not specified, the default value of 1 thread will be used. |
-| flink.connector.http.sink.writer.request.mode | optional | Sets
the Http Sink request submission mode. Two modes are available: `single` and
`batch`. Defaults to `batch` if not specified. |
-| flink.connector.http.sink.request.batch.size | optional |
Applicable only for `flink.connector.http.sink.writer.request.mode = batch`.
Sets number of individual events/requests that will be submitted as one HTTP
request by HTTP sink. The default value is 500 which is same as HTTP Sink
`maxBatchSize` |
+| http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
Review Comment:
I would assume we want continue on error so errors in the sink do not kill
the job. I am not sure if we can push the content of the error somehow into the
sink topic for errors. We could do this separately - maybe as a separate task
in the umbrella Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
