bharathgunapati commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r4039465768
##########
docs/content/docs/connectors/datastream/http.md:
##########
@@ -61,22 +61,31 @@ These options are specified on the builder using the
setProperty method.
| sink.requests.max-buffered | optional | Maximum
number of buffered records before applying backpressure.
|
| sink.flush-buffer.size | optional | The
maximum size of a batch of entries that may be sent to the HTTP endpoint
measured in bytes.
|
| sink.flush-buffer.timeout | optional |
Threshold time in milliseconds for an element to be in a buffer before being
flushed.
|
-| flink.connector.http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
Review Comment:
Agree we shouldn’t drop working options. This was a docs bug: the DataStream
page listed flink.connector.http.*, but since the GetInData donation the
runtime prefix has been http. (FLINK_CONNECTOR_HTTP = "http."), and the same
page’s code samples already used http.sink.*. Those documented keys were never
read if copied.
We fixed the docs to match the runtime. Legacy options that do exist
(http.sink.error.code / error.code.exclude) remain supported and documented; we
didn’t remove or reprefix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
