bharathgunapati commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r4039726714
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java:
##########
@@ -138,6 +138,38 @@ public final class HttpConnectorConfigConstants {
public static final String SINK_HTTP_WRITER_THREAD_POOL_SIZE =
FLINK_CONNECTOR_HTTP + "sink.writer.thread-pool.size";
+ public static final String SINK_MAX_RETRIES = FLINK_CONNECTOR_HTTP +
"sink.max-retries";
+
+ public static final String SINK_SUCCESS_CODES = FLINK_CONNECTOR_HTTP +
"sink.success-codes";
Review Comment:
Agree. We can follow the Kafka table pattern: shared connection-level
options (and for Kafka, client settings under properties.*), with scan.* /
sink.* only where behaviour differs.
For HTTP that would mean sharing truly common connection settings (and
parsing/docs), while keeping sink- and lookup-specific keys where values may
differ — e.g. a sink table with http.sink.request.timeout = 30s and a lookup
table with http.source.lookup.request.timeout = 5s in the same job. Table
options are per table, and DataStream sink/lookup each have their own config,
so those don’t collide.
Tracked as [FLINK-40702](https://issues.apache.org/jira/browse/FLINK-40702)
under FLINK-40275.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
