bharathgunapati commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r4039442098
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -596,12 +596,21 @@ another format name.
| http.sink.request-callback | optional | Specify which
`HttpPostRequestCallback` implementation to use. By default, it is set to
`slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
| http.sink.error.code | optional | List of HTTP status
codes that should be treated as errors by HTTP Sink, separated with comma.
|
| http.sink.error.code.exclude | optional | List of HTTP status
codes that should be excluded from the `http.sink.error.code` list, separated
with comma.
|
+| http.sink.success-codes | optional | Comma separated HTTP
status codes considered as successful sink responses. Use [1-5]XX for groups
and `!` for exclusions. The default is `2XX`. Ignored when the legacy
`http.sink.error.code` properties are set. |
Review Comment:
Agree. Sink creation now fails if legacy http.sink.error.code /
http.sink.error.code.exclude are set together with the new
http.sink.success-codes / http.sink.retry-codes, and if error.code.exclude is
set together with http.sink.ignored-response-codes. Defaults on the new options
do not count as set, so legacy-only jobs keep working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
