wenjin272 commented on issue #1193: URL: https://github.com/apache/flink-agents/issues/1193#issuecomment-6078265927
Thanks for outlining the options @da-daken. I prefer **A**: passing a `Skills` object should expose skills from those specific sources, while preserving any skill names explicitly configured on the chat-model descriptor. One clarification on timing: with cross-language repositories in #1214, skill discovery must happen at runtime, using the job’s classloader and initialized Python bridge/interpreter. At plan time, please only record the source declarations and the selection marker, not the actual skill names. At runtime, resolve the names through `SkillManager`, then merge them with the descriptor’s explicit names, keeping descriptor names first and deduplicating while preserving order. That final list can feed the existing prompt-generation and script-directory lookup paths. For the second point, aligning Java with Python’s level-aware precedence sounds reasonable: `@Skills` declarations → environment → agent, with later entries winning. Please document this behavior change and cover same-name conflicts across these levels in both languages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
