[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853864#comment-15853864
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99566630
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -741,6 +763,18 @@ private void establishJobManagerConnection(JobID
jobId, JobMasterGateway jobMast
jobManagerTable.put(jobId,
associateWithJobManager(jobMasterGateway, jobManagerLeaderId,
registrationSuccess.getBlobPort()));
}
+
heartbeatManager.monitorTarget(registrationSuccess.getResourceID(), new
HeartbeatTarget() {
+ @Override
+ public void sendHeartbeat(ResourceID resourceID, Object
payload) {
+
jobMasterGateway.heartbeatFromTaskManager(resourceID, payload);
+ }
+
+ @Override
+ public void requestHeartbeat(ResourceID resourceID,
Object payload) {
+ throw new UnsupportedOperationException("Should
never call requestHeartbeat in task manager.");
--- End diff --
A heartbeat request is totally fine. This should not throw an
`UnsupportedOperationException` but trigger a heartbeat being sent back to
`resourceID`.
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
