[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855207#comment-15855207
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann . Thank you for detail review and comments!
This PR just submit the heartbeat logic in TM side, because there is
already a jira of JM heartbeat side.
For my implementation, the JM initiates the heartbeat with
**HeartbeatManagerSenderImpl** and the TM responses the heartbeat with
**HeartbeatManagerImpl**. So the heartbeat process is one-way.
I think it is better to submit the JM heartbeat logic in this PR in order
to understand easily. I will modify this PR soon, and for testing there already
exists the UT for basic heartbeat logic. Do you mean to add some ITCases?
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
