[ 
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855154#comment-15855154
 ] 

ASF GitHub Bot commented on FLINK-4364:
---------------------------------------

Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r99731288
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
 ---
    @@ -218,4 +218,12 @@ void failSlot(final ResourceID taskManagerId,
                        final TaskManagerLocation taskManagerLocation,
                        final UUID leaderId,
                        @RpcTimeout final Time timeout);
    +
    +   /**
    +    * Send the heartbeat to job manager from task manager
    +    *
    +    * @param resourceID unique id of the task manager
    +    * @param payload the payload information from the task manager
    +    */
    +   void heartbeatFromTaskManager(final ResourceID resourceID, final Object 
payload);
    --- End diff --
    
    Currently we have not considered which specific payload information should 
be attached with the heartbeat, so use the object to work around.  It should be 
changed to specific type if confirmation. Do you think which payload should be 
attached necessary currently?


> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
>                 Key: FLINK-4364
>                 URL: https://issues.apache.org/jira/browse/FLINK-4364
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and 
> the {{TaskManager}} will report metrics info for each heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to