[jira] [Commented] (GEODE-2601) Banner is logged twice during locator startup

[Emily Yeh (JIRA)]

    [ 
https://issues.apache.org/jira/browse/GEODE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039576#comment-16039576
 ] 

Emily Yeh commented on GEODE-2601:
----------------------------------

This might not be a bug. Since a distributed system can exist without a 
locator, and a locator can exist without a distributed system, both log the 
banner.

For reference, the first banner is logged in `InternalLocator.java` here:
{noformat}
logWriter = LogWriterFactory.createLogWriterLogger(false, false, this.config, 
!startDistributedSystem);
{noformat}

And the second banner is logged in `InternalDistributedSystem.java` here:
{noformat}
this.logWriter = LogWriterFactory.createLogWriterLogger(this.isLoner, false, 
this.config, true);
{noformat}

Both log the banners here, in `LogWriterFactory.java`:
{noformat}
// log the banner
if (!Boolean.getBoolean(InternalLocator.INHIBIT_DM_BANNER)) {
  if (InternalDistributedSystem.getReconnectAttemptCounter() == 0 // avoid 
filling up logs
                                                                  // during 
auto-reconnect
      && !isSecure // && !isLoner /* do this on a loner to fix bug 35602 */
  ) {
    // LOG:CONFIG:
    logger.info(LogMarker.CONFIG, Banner.getString(null));
  }
} else {
  logger.debug("skipping banner - " + InternalLocator.INHIBIT_DM_BANNER + " is 
set to true");
}
{noformat}

> Banner is logged twice during locator startup
> ---------------------------------------------
>
>                 Key: GEODE-2601
>                 URL: https://issues.apache.org/jira/browse/GEODE-2601
>             Project: Geode
>          Issue Type: Bug
>          Components: logging
>            Reporter: Patrick Rhomberg
>            Assignee: Emily Yeh
>            Priority: Minor
>              Labels: LogBanner
>
> In locator log file, starting a locator in gfsh yields a log file containing 
> "Licensed to the Apache [...]"
> First banner ends with:
> {noformat}[info 2017/03/06 14:29:29.995 PST loc1 <main> tid=0x1] Starting 
> peer location for Distribution Locator on 10.118.33.239{noformat}
> Second banner ends with:
> {noformat}[info 2017/03/06 14:29:30.160 PST loc1 <main> tid=0x1] Starting 
> membership services{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)