[
https://issues.apache.org/jira/browse/GEODE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043671#comment-16043671
]
ASF GitHub Bot commented on GEODE-2601:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/571
GEODE-2601: Fixing banner being logged twice during locator startup
Now only logs once if both locator and distributed systems are started!
There appear to be some minor changes in various places, possibly due to
spotless checking; the main changes are in **lines 616-617 of
`InternalDistributedSystem.java`** and **lines 483-484 of
`InternalLocator.java`**. Patrick (@PurelyApplied) also noticed an unnecessary
`if` statement in **lines 95 & 96 of `LogWriterFactory.java`**, which has been
fixed in this PR.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-2601-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #571
----
commit d0c07e7bd0d938649ad9b49e2da1bc135145218f
Author: YehEmily <[email protected]>
Date: 2017-06-08T21:40:39Z
GEODE-2601: Fixing banner being logged twice during locator startup (now
only logs once if both locator and distributed systems are started)
----
> Banner is logged twice during locator startup
> ---------------------------------------------
>
> Key: GEODE-2601
> URL: https://issues.apache.org/jira/browse/GEODE-2601
> Project: Geode
> Issue Type: Bug
> Components: logging
> Reporter: Patrick Rhomberg
> Assignee: Emily Yeh
> Priority: Minor
> Labels: LogBanner
>
> In locator log file, starting a locator in gfsh yields a log file containing
> "Licensed to the Apache [...]"
> First banner ends with:
> {noformat}[info 2017/03/06 14:29:29.995 PST loc1 <main> tid=0x1] Starting
> peer location for Distribution Locator on 10.118.33.239{noformat}
> Second banner ends with:
> {noformat}[info 2017/03/06 14:29:30.160 PST loc1 <main> tid=0x1] Starting
> membership services{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
