[
https://issues.apache.org/jira/browse/GEODE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051185#comment-16051185
]
ASF GitHub Bot commented on GEODE-2601:
---------------------------------------
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122332566
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -2167,7 +2191,7 @@ private static void
notifyReconnectListeners(InternalDistributedSystem oldsys,
private void notifyResourceEventListeners(ResourceEvent event, Object
resource) {
for (Iterator<ResourceEventsListener> iter =
resourceListeners.iterator(); iter.hasNext();) {
--- End diff --
This loop looks like it could be rewritten as a foreach type loop
`
for (ResourceEventListnener listener:resourceListeners) {
...
}
`
> Banner is logged twice during locator startup
> ---------------------------------------------
>
> Key: GEODE-2601
> URL: https://issues.apache.org/jira/browse/GEODE-2601
> Project: Geode
> Issue Type: Bug
> Components: logging
> Reporter: Patrick Rhomberg
> Assignee: Emily Yeh
> Priority: Minor
> Labels: LogBanner
>
> In locator log file, starting a locator in gfsh yields a log file containing
> "Licensed to the Apache [...]"
> First banner ends with:
> {noformat}[info 2017/03/06 14:29:29.995 PST loc1 <main> tid=0x1] Starting
> peer location for Distribution Locator on 10.118.33.239{noformat}
> Second banner ends with:
> {noformat}[info 2017/03/06 14:29:30.160 PST loc1 <main> tid=0x1] Starting
> membership services{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
