[ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071668#comment-16071668
 ] 

ASF GitHub Bot commented on GEODE-2891:
---------------------------------------

Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/105#discussion_r125184959
  
    --- Diff: src/cppcache/src/TcrMessage.hpp ---
    @@ -171,7 +173,8 @@ class CPPCACHE_EXPORT TcrMessage {
         GET_DURABLE_CQS_DATA_ERROR = 106,
         GET_ALL_WITH_CALLBACK = 107,
         PUT_ALL_WITH_CALLBACK = 108,
    -    REMOVE_ALL = 109
    +   REMOVE_ALL = 109,
    +   HANDSHAKE = 110
    --- End diff --
    
    These numbers correspond to protocol message numbers on the server. We can 
just add one here and expect it not cause issues later.


> connect-timeout violation in C++ Native Client
> ----------------------------------------------
>
>                 Key: GEODE-2891
>                 URL: https://issues.apache.org/jira/browse/GEODE-2891
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Gregory Vortman
>         Attachments: GEODE-connect-timeout-violation.docx
>
>
> 1.    C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.    The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to