[
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071669#comment-16071669
]
ASF GitHub Bot commented on GEODE-2891:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184917
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -703,15 +717,21 @@ inline ConnErrType TcrConnection::sendData(uint32_t&
timeSpent,
is not public yet*/
notPublicApiWithTimeout == TcrMessage::EXECUTE_FUNCTION ||
notPublicApiWithTimeout == TcrMessage::EXECUTE_REGION_FUNCTION ||
- notPublicApiWithTimeout ==
- TcrMessage::EXECUTE_REGION_FUNCTION_SINGLE_HOP) {
- // then app has set timeout in millis, change it to microSeconds
- sendTimeoutSec = sendTimeoutSec * 1000;
- isPublicApiTimeout = true;
- LOGDEBUG("sendData2 %d ", sendTimeoutSec);
- } else {
- sendTimeoutSec = sendTimeoutSec * 1000;
- }
+ notPublicApiWithTimeout ==
TcrMessage::EXECUTE_REGION_FUNCTION_SINGLE_HOP ||
+ // GT GEODE-2891
+ notPublicApiWithTimeout == TcrMessage::HANDSHAKE)
+ {
+ // then app has set timeout in millis, change it to microSeconds
+ sendTimeoutSec = sendTimeoutSec * 1000;
+ isPublicApiTimeout = true;
+ LOGDEBUG("sendData2 %d ", sendTimeoutSec);
+ }
--- End diff --
Formatting does not conform to [Google C++ Style
Guide](https://google.github.io/styleguide/cppguide.html).
> connect-timeout violation in C++ Native Client
> ----------------------------------------------
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Gregory Vortman
> Attachments: GEODE-connect-timeout-violation.docx
>
>
> 1. C++ native client doesn’t honour read-timeout-milli-sec in a consistent
> way while connecting to a server
> 2. The lock on the connection pool has a very high granularity. Even if
> the client can’t connect to one server, all other threads which are working
> with totally different servers get affected by it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
