[
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074890#comment-16074890
]
ASF GitHub Bot commented on GEODE-2891:
---------------------------------------
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 a couple quick items of feedback that need to be addressed
before this is reviewed:
- please squash your commits, this cleans up the diffs for everyone to
better review your contribution
please close [#105](https://github.com/apache/geode-native/pull/105) as
duplicate of this PR
- please have a look at the [Code
Contribution](https://cwiki.apache.org/confluence/display/GEODE/Code+contributions)
section of the WIKI
-- for one you will see that we are using GitFlow and your PR should be
coming in from a feature branch (e.g. feature/GEODE-2891) instead of your
develop branch
Thanks!
> connect-timeout violation in C++ Native Client
> ----------------------------------------------
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Gregory Vortman
> Attachments: GEODE-connect-timeout-violation.docx
>
>
> 1. C++ native client doesn’t honour read-timeout-milli-sec in a consistent
> way while connecting to a server
> 2. The lock on the connection pool has a very high granularity. Even if
> the client can’t connect to one server, all other threads which are working
> with totally different servers get affected by it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
