[
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076555#comment-16076555
]
ASF GitHub Bot commented on GEODE-2891:
---------------------------------------
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Did I understood correct that there are no issues found during the code
review in the reviewed code? Probably the decision regarding the accepting of
the pull request doesn’t depend in this case on the code quality but should
depend on ETA for GEODE-3136<https://issues.apache.org/jira/browse/GEODE-3136>
and GEODE-3137<https://issues.apache.org/jira/browse/GEODE-3136>, on the
appropriate next client version deployment readiness et cetera. If these dates
will be published, that will assist us within the company to take decision
whether we may wait for this client version or will require to accept the pull
request even as the temporary fix.
Thanks,
Dr. Gregory Turovets
From: Jacob Barrett [mailto:[email protected]]
Sent: Wednesday, July 05, 2017 17:41
To: apache/geode-native <[email protected]>
Cc: Gregory Turovets <[email protected]>; Author
<[email protected]>
Subject: Re: [apache/geode-native] GEODE-2891 connect-timeout violation in
C++ Native Client (#106)
@pivotal-jbarrett requested changes on this pull request.
I am not in favor of accepting this pull request on the heals of correcting
all timeouts via GEODE-3136<https://issues.apache.org/jira/browse/GEODE-3136>
and GEODE-3137<https://issues.apache.org/jira/browse/GEODE-3136> as mentioned
in pull #105<https://github.com/apache/geode-native/pull/105>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/geode-native/pull/106#pullrequestreview-48073734>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AbZcfvST1gIEk8aYilBGwKHkEhPC0_ecks5sK6CXgaJpZM4OOTnp>.
This message and the information contained herein is proprietary and
confidential and subject to the Amdocs policy statement,
you may review at https://www.amdocs.com/about/email-disclaimer
<https://www.amdocs.com/about/email-disclaimer>
> connect-timeout violation in C++ Native Client
> ----------------------------------------------
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Gregory Vortman
> Assignee: Jacob S. Barrett
> Attachments: GEODE-connect-timeout-violation.docx
>
>
> 1. C++ native client doesn’t honour read-timeout-milli-sec in a consistent
> way while connecting to a server
> 2. The lock on the connection pool has a very high granularity. Even if
> the client can’t connect to one server, all other threads which are working
> with totally different servers get affected by it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
