[
https://issues.apache.org/jira/browse/GEODE-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144408#comment-16144408
]
ASF GitHub Bot commented on GEODE-3529:
---------------------------------------
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/746
GEODE-3529 move new client/server security classes to a different pac…
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype
The new classes/interfaces have been moved to
org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3529
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit ed3ac98cec1610bde2c1cbcad5a0ff542296ea2a
Author: Bruce Schuchardt <[email protected]>
Date: 2017-08-28T21:43:45Z
GEODE-3529 move new client/server security classes to a different package
The new classes/interfaces have been moved to
org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
----
> move new client/server security classes to a different package
> --------------------------------------------------------------
>
> Key: GEODE-3529
> URL: https://issues.apache.org/jira/browse/GEODE-3529
> Project: Geode
> Issue Type: Task
> Components: client/server
> Reporter: Bruce Schuchardt
> Fix For: 1.3.0
>
>
> The StreamAuthenticator, StreamAuthorizer and associated classes were put in
> the org.apache.geode.security package but they are only peripherally
> associated with the other classes in that package. They should be moved to a
> different package that has its own package.html.
> The "Stream" name should be removed since they are intended for client/server
> authentication and authorization and _not_ authentication of streams in
> general. Also, the method "receiveMessage" seems an odd name for requesting
> authentication. Perhaps "authenticate" would be better?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
