[
https://issues.apache.org/jira/browse/GEODE-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145952#comment-16145952
]
ASF GitHub Bot commented on GEODE-3529:
---------------------------------------
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135888279
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -41,8 +41,8 @@ private synchronized void initializeAuthenticatorsMap() {
return;
}
authenticators = new HashMap<>();
- ServiceLoader<StreamAuthenticator> loader =
ServiceLoader.load(StreamAuthenticator.class);
- for (StreamAuthenticator streamAuthenticator : loader) {
+ ServiceLoader<Authenticator> loader =
ServiceLoader.load(Authenticator.class);
+ for (Authenticator streamAuthenticator : loader) {
--- End diff --
The "stream" concept is fine in the cache.tier.sockets package - there are
other uses of it there.
> move new client/server security classes to a different package
> --------------------------------------------------------------
>
> Key: GEODE-3529
> URL: https://issues.apache.org/jira/browse/GEODE-3529
> Project: Geode
> Issue Type: Task
> Components: client/server
> Reporter: Bruce Schuchardt
> Fix For: 1.3.0
>
>
> The StreamAuthenticator, StreamAuthorizer and associated classes were put in
> the org.apache.geode.security package but they are only peripherally
> associated with the other classes in that package. They should be moved to a
> different package that has its own package.html.
> The "Stream" name should be removed since they are intended for client/server
> authentication and authorization and _not_ authentication of streams in
> general. Also, the method "receiveMessage" seems an odd name for requesting
> authentication. Perhaps "authenticate" would be better?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
