[
https://issues.apache.org/jira/browse/GEODE-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145828#comment-16145828
]
ASF GitHub Bot commented on GEODE-3529:
---------------------------------------
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135871358
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -57,15 +57,14 @@ private synchronized ClientProtocolMessageHandler
initializeMessageHandler() {
return protocolHandler;
}
- private StreamAuthenticator findStreamAuthenticator(String
implementationID) {
+ private Authenticator findStreamAuthenticator(String implementationID) {
if (authenticators == null) {
initializeAuthenticatorsMap();
}
- Class<? extends StreamAuthenticator> streamAuthenticatorClass =
- authenticators.get(implementationID);
+ Class<? extends Authenticator> streamAuthenticatorClass =
authenticators.get(implementationID);
--- End diff --
stream in variable name
> move new client/server security classes to a different package
> --------------------------------------------------------------
>
> Key: GEODE-3529
> URL: https://issues.apache.org/jira/browse/GEODE-3529
> Project: Geode
> Issue Type: Task
> Components: client/server
> Reporter: Bruce Schuchardt
> Fix For: 1.3.0
>
>
> The StreamAuthenticator, StreamAuthorizer and associated classes were put in
> the org.apache.geode.security package but they are only peripherally
> associated with the other classes in that package. They should be moved to a
> different package that has its own package.html.
> The "Stream" name should be removed since they are intended for client/server
> authentication and authorization and _not_ authentication of streams in
> general. Also, the method "receiveMessage" seems an odd name for requesting
> authentication. Perhaps "authenticate" would be better?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
