[
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245215#comment-16245215
]
ASF GitHub Bot commented on GEODE-3420:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #143: GEODE-3420: Remove
inline header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r149868539
##########
File path: cppcache/include/geode/CacheableBuiltins.hpp
##########
@@ -642,6 +642,16 @@ _GF_CACHEABLE_CONTAINER_TYPE_DEF_(HashSetOfCacheableKey,
*/
_GF_CACHEABLE_CONTAINER_TYPE_(HashSetOfCacheableKey, CacheableLinkedHashSet);
+template <>
+inline CacheableKeyPtr CacheableKey::create(int value) {
Review comment:
Why only these two specializations here? I would also prefer we say
`int32_t` rather than `int` to be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove all .inl files
> ---------------------
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes
> and templates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
