[
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245848#comment-16245848
]
ASF GitHub Bot commented on GEODE-3420:
---------------------------------------
dgkimura commented on a change in pull request #143: GEODE-3420: Remove inline
header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r149996533
##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -308,6 +308,31 @@ inline CacheablePtr createValueArr(const wchar_t* value) {
return CacheableString::create(value);
}
+template <typename TVALUE>
+inline CacheablePtr createValue(const TVALUE* value) {
+ return CacheableString::create(value);
+}
Review comment:
This came from `Cacheable.inl` template function `createValue(const TVALUE*
value)` which called `createValueArr` which is only defined in
`CacheableString.hpp`. So intent was to unroll that. I didn't move it to
`Cacheable.hpp` because then `Cacheable.hpp` and `CacheableString.hpp` would
have circular dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove all .inl files
> ---------------------
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes
> and templates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
