[
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245214#comment-16245214
]
ASF GitHub Bot commented on GEODE-3420:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #143: GEODE-3420: Remove
inline header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r149868339
##########
File path: cppcache/include/geode/Cacheable.hpp
##########
@@ -35,10 +35,10 @@ typedef SerializablePtr CacheablePtr;
typedef Serializable Cacheable;
template <typename TVALUE>
-inline CacheablePtr createValue(const std::shared_ptr<TVALUE>& value);
+inline CacheablePtr createValue(const std::shared_ptr<TVALUE>& value) {
Review comment:
I know you are just moving this but I really don't see the utility in this.
I feel like this is a hold over from some really old magic with the old
SharedPtr. All we have here now is a redefinition of dynamic cast. If we can
get rid of this then let's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove all .inl files
> ---------------------
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes
> and templates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
