[
https://issues.apache.org/jira/browse/HAWQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052471#comment-15052471
]
ASF GitHub Bot commented on HAWQ-234:
-------------------------------------
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/169#discussion_r47333137
--- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
@@ -464,24 +471,23 @@ int cleanupQD2RMComm(void)
{
if ( QD2RM_ResourceSets[i]->QD_ResourceList != NULL )
{
- elog(LOG, "Un-returned resource is probed, will be
returned. "
- "(%d MB, %lf CORE) x %d. Conn ID=%d",
- QD2RM_ResourceSets[i]->QD_SegMemoryMB,
- QD2RM_ResourceSets[i]->QD_SegCore,
- QD2RM_ResourceSets[i]->QD_SegCount,
- QD2RM_ResourceSets[i]->QD_Conn_ID);
-
+ elog(WARNING, "Un-returned resource is probed, will be
returned. "
+ "(%d MB, %lf CORE) x %d. Conn ID=%d",
+
QD2RM_ResourceSets[i]->QD_SegMemoryMB,
+
QD2RM_ResourceSets[i]->QD_SegCore,
+
QD2RM_ResourceSets[i]->QD_SegCount,
+
QD2RM_ResourceSets[i]->QD_Conn_ID);
+ errorbuf[0] = '\0';
res = returnResource(i, errorbuf, sizeof(errorbuf));
if ( res != FUNC_RETURN_OK )
{
- elog(WARNING, "Failed to return resource when cleaning
up "
- "resource context.");
+ elog(WARNING, "%s", errorbuf);
--- End diff --
in line 480 errorbuf[0] = '\0'; so line 484 will elog warning an empty
string?
> Improve HAWQ resource manager resource allocation algorithm and RPC framework
> -----------------------------------------------------------------------------
>
> Key: HAWQ-234
> URL: https://issues.apache.org/jira/browse/HAWQ-234
> Project: Apache HAWQ
> Issue Type: Improvement
> Components: Resource Manager
> Reporter: Yi Jin
> Assignee: Yi Jin
>
> 1) reject resource request from dispatcher at once if too many segments
> unavailable;
> 2) explain how many segments unavailable in current cluster when the resource
> request is rejected;
> 3) make error message string generated in resource manager process only for
> all resource manager RPCs;
> 4) change NVSEG_* limits semantic meanings to latest version;
> 5) minimum vseg number for one resource request is changed to queue vseg num
> / active_statements, but the request having only a few vseg required is not
> changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
