[
https://issues.apache.org/jira/browse/HAWQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052541#comment-15052541
]
ASF GitHub Bot commented on HAWQ-234:
-------------------------------------
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/169#discussion_r47336814
--- Diff: src/backend/resourcemanager/resqueuemanager.c ---
@@ -2165,103 +2165,87 @@ void cancelResourceAllocRequest(ConnectionTrack
conntrack)
/* Unlock session in deadlock */
unlockSessionResource(&(queuetrack->DLDetector), conntrack->SessionID);
- buildTimeoutResponseForQueuedRequest(conntrack,
RESQUEMGR_NORESOURCE_TIMEOUT);
+ buildTimeoutResponseForQueuedRequest(conntrack,
+
RESQUEMGR_NORESOURCE_TIMEOUT,
+
errorbuf);
}
/* Acquire resource from queue. */
-int acquireResourceFromResQueMgr(ConnectionTrack conntrack)
+int acquireResourceFromResQueMgr(ConnectionTrack conntrack,
+ char
*errorbuf,
+ int
errorbufsize)
{
- int res
= FUNC_RETURN_OK;
-
- DynResourceQueueTrack queuetrack = conntrack->QueueTrack;
-
- if ( queuetrack->ClusterSegNumberMax == 0 )
- {
- elog(LOG, "The queue %s has no resource available to run
queries.",
- queuetrack->QueueInfo->Name);
- return RESQUEMGR_NO_RESOURCE;
- }
+ int res
= FUNC_RETURN_OK;
--- End diff --
format problem
> Improve HAWQ resource manager resource allocation algorithm and RPC framework
> -----------------------------------------------------------------------------
>
> Key: HAWQ-234
> URL: https://issues.apache.org/jira/browse/HAWQ-234
> Project: Apache HAWQ
> Issue Type: Improvement
> Components: Resource Manager
> Reporter: Yi Jin
> Assignee: Yi Jin
>
> 1) reject resource request from dispatcher at once if too many segments
> unavailable;
> 2) explain how many segments unavailable in current cluster when the resource
> request is rejected;
> 3) make error message string generated in resource manager process only for
> all resource manager RPCs;
> 4) change NVSEG_* limits semantic meanings to latest version;
> 5) minimum vseg number for one resource request is changed to queue vseg num
> / active_statements, but the request having only a few vseg required is not
> changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
