[ 
https://issues.apache.org/jira/browse/HAWQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052481#comment-15052481
 ] 

ASF GitHub Bot commented on HAWQ-234:
-------------------------------------

Github user zhangh43 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/169#discussion_r47333451
  
    --- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
    @@ -807,7 +839,8 @@ int acquireResourceFromRM(int                           
  index,
                newqdseg->QD_HdfsHostName = (hnameidxarray[i] < nodecount) ?
                                                                        
curcontext->QD_HdfsHostNames[hnameidxarray[i]] :
                                                                                
NULL;
    -           newqdseg->QD_SegInfo = (SegInfo)(recvbuffer->Buffer + 
hoffsetarray[i]);
    +           newqdseg->QD_SegInfo = (SegInfo)(SMBUFF_CONTENT(recvbuffer) +
    +                                                                           
 hoffsetarray[i]);
    --- End diff --
    
    there are some format problem in this file


> Improve HAWQ resource manager resource allocation algorithm and RPC framework
> -----------------------------------------------------------------------------
>
>                 Key: HAWQ-234
>                 URL: https://issues.apache.org/jira/browse/HAWQ-234
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: Resource Manager
>            Reporter: Yi Jin
>            Assignee: Yi Jin
>
> 1) reject resource request from dispatcher at once if too many segments 
> unavailable;
> 2) explain how many segments unavailable in current cluster when the resource 
> request is rejected;
> 3) make error message string generated in resource manager process only for 
> all resource manager RPCs;
> 4) change NVSEG_* limits semantic meanings to latest version;
> 5) minimum vseg number for one resource request is changed to queue vseg num  
> /  active_statements, but the request having only a few vseg required is not 
> changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to