[ 
https://issues.apache.org/jira/browse/HAWQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052533#comment-15052533
 ] 

ASF GitHub Bot commented on HAWQ-234:
-------------------------------------

Github user zhangh43 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/169#discussion_r47336522
  
    --- Diff: src/backend/resourcemanager/resourcepool.c ---
    @@ -1153,7 +1156,7 @@ int setSegResHAWQAvailability( SegResource segres, 
uint8_t newstatus)
     
     int setSegResGLOBAvailability( SegResource segres, uint8_t newstatus)
     {
    -   return setSegStatGLOBAvailability(segres->Stat, newstatus);
    +   int res = setSegStatGLOBAvailability(segres->Stat, newstatus);
    --- End diff --
    
    here should add "return res;"


> Improve HAWQ resource manager resource allocation algorithm and RPC framework
> -----------------------------------------------------------------------------
>
>                 Key: HAWQ-234
>                 URL: https://issues.apache.org/jira/browse/HAWQ-234
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: Resource Manager
>            Reporter: Yi Jin
>            Assignee: Yi Jin
>
> 1) reject resource request from dispatcher at once if too many segments 
> unavailable;
> 2) explain how many segments unavailable in current cluster when the resource 
> request is rejected;
> 3) make error message string generated in resource manager process only for 
> all resource manager RPCs;
> 4) change NVSEG_* limits semantic meanings to latest version;
> 5) minimum vseg number for one resource request is changed to queue vseg num  
> /  active_statements, but the request having only a few vseg required is not 
> changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to